MyAlerts alteration

[euantor]

First of all, IDK if you're using the latest version of MyAlerts here or not. Second, I'll likely be adding this code snippet to the next version but I'd love to see it manually added here in the meantime. I can't believe I overlooked it.

https://github.com/euantor/MyAlerts/wiki/Closing-the-alerts-popup-when-clicking-outside

 

[Solidus1]

It is for me. Better revert that change though.

 

[euantor]

Or it may be because the MyAlerts JS is in the headerinclude twice.

 

[Solidus1]

Okay, removed one and added the code back. How is it?
---
Now I can't open them.

 

[euantor]

The menu does now open but the previous issue of clicking within the menu still occurs.

 

[Solidus1]

Can't even open it now, with or without the code above.

 

[euantor]

Odd indeed. I assume you've done a hard refresh etc? Check the source and post what is shown in the myalerts.js file please as it's working perfectly for me.

 

[Solidus1]

Every time. Try Firefox.

jQuery.noConflict();

jQuery(document).ready(function($)
{

$("body:not('.myalerts_popup:visible')").on('click', function() {
    $('.myalerts_popup:visible').slideToggle("fast");
});

$('.myalerts_popup > *').on('click', function(event) {
    event.stopPropagation();
}); 

	$('body').on({
		click: function(event)
		{
			event.preventDefault();
			var popup_id = $(this).attr('id') + '_popup';

			$('#' + popup_id).attr('top', $(this).height() + 'px').slideToggle('slow', function() {
				var toMarkRead = new Array;
				$('[id^="alert_row_popup_"]').each(function() {
					toMarkRead.push($(this).attr('id').substr(16));
				});

				$.get('xmlhttp.php?action=markRead', {
					my_post_key: my_post_key,
					toMarkRead: toMarkRead
				}, function(data) {

				});
			});
			return false;
		}
	}, '.myalerts_popup_hook');

	$('#getUnreadAlerts').on('click', function(event) {
		event.preventDefault();
		$.get('xmlhttp.php?action=getNewAlerts', function(data) {
			$('#latestAlertsListing').prepend(data);
		});
	});

	$('.deleteAlertButton').on('click', function(event) {
		event.preventDefault();
		var deleteButton = $(this);

		$.getJSON(deleteButton.attr('href'), {accessMethod: 'js'}, function(data) {
			if (data['success'])
			{
				deleteButton.parents('tr').get(0).remove();
				if (data['template'])
				{
					$('#latestAlertsListing').html(data['template']);
				}
			}
			else
			{
				alert(data['error']);
			}
		});
	});

	if (typeof myalerts_autorefresh !== 'undefined' && myalerts_autorefresh > 0)
	{
		window.setInterval(function() {
			$.get('xmlhttp.php?action=getNewAlerts', function(data) {
				$('#latestAlertsListing').prepend(data);
			});
		}, myalerts_autorefresh * 1000);
	}

	if (typeof unreadAlerts !== 'undefined' && unreadAlerts > 0)
	{
		document.title = document.title + ' (' + unreadAlerts + ')';
	}

});

 

[Solidus1]

Yep, it's Firefox. Opera works.

 

[Crayo]

Works fine for me with Chrome to. Since when did Firefox turn into Internet Exporer btw? I swear there's been a few FF issues popping up recently.

 

[euantor]

Odd indeed. No idea why it wouldn't work in firefox. I'll have to look into it.