MyAlerts alteration

[euantor]

First of all, IDK if you're using the latest version of MyAlerts here or not. Second, I'll likely be adding this code snippet to the next version but I'd love to see it manually added here in the meantime. I can't believe I overlooked it.

https://github.com/euantor/MyAlerts/wiki/Closing-the-alerts-popup-when-clicking-outside

 

[Solidus1]

Added.

 

[Crayo]

CTRL + F5'd and it still doesn't close when I click off it. Though I believe I went to edit that file the same time Solidus did, so inb4 I've ruined something.

 

[euantor]

It needs to go in the jQuery block

 

[Solidus1]

It works.

 

[euantor]

Aye, it does now it's in the jQuery block

 

[Crayo]

:terry:

This makes things easier though, nice change. Are we the first btw?

 

[euantor]

Nah. I posted the code ages back in the release thread but completely forgot about it till I got an alert here earlier.

 

[Crayo]

Well that's depressing. No idea what version we are using by the way, I can't remember. Probably not the latest, but I assume it doesn't matter?

 

[Solidus1]

It is the latest version I think, only PluginLibrary is outdated.
Btw Crayo, I renamed all instances of 'alert' and 'alerts' to 'notification' and 'notifications'. I think you forgot that.

 

[Crayo]

Yeah we got all lazy. Thanks lol.

Btw, it's a little annoying if you mis-click on the down-down and it still closes. I think it should only click off if you click outside the drop-down, not if you click in it as well. Make sense or not?

 

[euantor]

It's probably up to date with the mods site. I pushed a few changes to GitHub to fix the issues you were experiencing here where when alerts were disabled people still received them though.

__________

Yeah we got all lazy. Thanks lol.

Btw, it's a little annoying if you mis-click on the down-down and it still closes. I think it should only click off if you click outside the drop-down, not if you click in it as well. Make sense or not?

Ah, didn't think of that. Try adding this:

$('.myalerts_popup > *').on('click', function(event) {
    event.stopPropagation();
});

 

[Solidus1]

^ that works.
Also Crayo, I added settings next to 'View Notification', I read somewhere you wanted that.

 

[Crayo]

The drop down won't open for me now so I can't see lol

 

[euantor]

Yeah, it isn't opening for me either. I may have bodged that code lol